Default to StartProxyRemoveUnusedRegistries behaviour#3909
Open
mbg wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the StartProxyRemoveUnusedRegistries feature flag and makes its behaviour the default, so unused registries are always skipped based on the language being analysed.
Changes:
- Drop the feature flag and its
featureConfigentry. - Remove the old
LANGUAGE_TO_REGISTRY_TYPEand rename theNEW_*variant toLANGUAGE_TO_REGISTRY_TYPE; simplifygetCredentialsby removing theskipUnusedRegistriesparameter. - Update
start-proxy-action.tsto no longer query the flag, and adjust tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| src/start-proxy.ts | Consolidates registry mapping to one constant and removes the skipUnusedRegistries parameter from getCredentials. |
| src/start-proxy.test.ts | Updates tests to match the new signature and removes the now-redundant Actions test case. |
| src/start-proxy-action.ts | Removes the feature flag query and unused Feature import. |
| src/feature-flags.ts | Removes the StartProxyRemoveUnusedRegistries enum value and config entry. |
| lib/upload-lib.js, lib/entry-points.js | Generated JS reflecting the source changes. |
Copilot's findings
- Files reviewed: 4/6 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
StartProxyRemoveUnusedRegistriesand defaults to the new behaviour.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist